Regression in v0.20.2

[aanm]

Hello, a regression was found in v0.20.2 caused by #3100

This breaks Cilium Operator initialization with the following error:

panic: descriptor Desc{fqName: "go_sched_latencies_seconds", help: "Distribution of the time goroutines have spent in the scheduler in a runnable state before actually running. Bucket counts increase monotonically. Sourced from /sched/latencies:seconds.", constLabels: {}, variableLabels: {}} already exists with the same fully-qualified name and const label values

Is it possible to revert the PR? /cc @sbueringer

Thanks

[sbueringer]

For my understanding. You depend on us only exposing some of the Go runtime metrics?

[sbueringer]

I'm okay to revert this for the patch releases, but I wouldn't revert it on main (aka for the next minor release)

[alvaroaleman]

Reverting this is a breaking change as well for anyone who depends on this metric, so I am not in favor of that. Can you explain why you can not fix this on your end?

[sbueringer]

Good point

[alvaroaleman]

Actually sorry, I am just seeing we added this in a patch release, not a minor. I do agree we should revert this then

[sbueringer]

Yeah that's what I was thinking 😅

I didn't see the potential for breaking anyone when backporting this

[sbueringer]

Merged & released new patch releases

/close

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

Merged & released new patch releases

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dongjiang1989]

@aanm

Maybe in the future, when upgrading to v0.21.x, you will also need to make slight changes to the duplicate registration.

1. Change MustRegister to Register
2. Unregister first and then MustRegister

ref: https://github.com/prometheus/client_golang/blob/main/prometheus/registry.go#L96-L134

cc @sbueringer @alvaroaleman

[sbueringer]

Thx for adding that explanation @dongjiang1989