clean up makefile and CI targets #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the top-level Makefile in anticipation for integrating more targets with prow. Prow e2e tests will be driven by a script in hack instead of a make target because prow will need special setup compared to user envs that are more flexible. Currently the script is a non-functional placeholder to ensure prow integration can be done without worrying about the script having unexpected bugs. A future PR will follow up to fill in the e2e script, which can be debugged at that time. Similarly, a placeholder script was created for checking that code/file generation scripts were run by contributors that can be debugged after prow integration. There was a minor bug running `make codegen` that was fixed. Documentation was removed from tool targets to ensure `make help` output is kept small to help new contributors. Signed-off-by: Blaine Gardner <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the top-level Makefile in anticipation for integrating more targets with prow.
Prow e2e tests will be driven by a script in hack
instead of a make target because prow will need special setup compared to user envs that are more flexible. Currently the script is a non-functional placeholder to ensure prow integration can be done without worrying about the script having unexpected bugs. A future PR will follow up to fill in the e2e script, which can be debugged at that time.
Similarly, a placeholder script was created for checking that code/file generation scripts were run by contributors that can be debugged after prow integration.
There was a minor bug running
make codegenthat was fixed. Documentation was removed from tool targets to ensuremake helpoutput is kept small to help new contributors.After this PR, prow config will be updated to run these tests:
make testmake lintmake build(ormake allif we think build should run codegen steps)./hack/prow-e2e.sh./hack/prow-check-generate.shAfter Prow is updated and runs with new PRs, we can add content to
./hack/prow-e2e.shand./hack/prow-check-generate.sh. If we add content to these files now, we don't know if there will be errors running them, and prow config might not pass its own CI.