gomod: use top level go mod for controller/sidecar #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
BlaineEXE
force-pushed
the
gomod-use-top-level-gomod-for-controller-and-sidecar
branch
from
6b8fefe to
5632027
Compare
BlaineEXE
commented
Apr 24, 2025
| controller-gen.kubebuilder.io/version: v0.16.4 | ||
| controller-gen.kubebuilder.io/version: v0.17.3 |
There was a problem hiding this comment.
This change isn't ideal, but it seems to be because of #39
Dependabot updated the lib, but it doesn't know how to run make generate, so this didn't appear until my PR here. We might want to follow up with dependabot config to handle controller-gen differently in the future
To help with dependency management, shift from using separate go mods for controller and sidecar, and instead use a top level go mod for these buildable components. client and proto still have separate go (sub)mods because they are pulled in by drivers or other operators, and keeping their dependency lists small is important. This also allows us to deduplicate the vendor dir that was previously kept separately for both components. Signed-off-by: Blaine Gardner <[email protected]>
BlaineEXE
force-pushed
the
gomod-use-top-level-gomod-for-controller-and-sidecar
branch
from
5632027 to
19e639b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with dependency management, shift from using separate go mods for controller and sidecar, and instead use a top level go mod for these buildable components. client and proto still have separate go (sub)mods because they are pulled in by drivers or other operators, and keeping their dependency lists small is important.
This also allows us to deduplicate the vendor dir that was previously kept separately for both components.