This repository was archived by the owner on Dec 3, 2024. It is now read-only.
removes endpoint, bucketName fields from protocol structs #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign wlan0 |
|
/approve |
k8s-ci-robot
added
the
lgtm
krishchow
force-pushed
the
remove-protocol-name
branch
from
e4e8ca2 to
984874f
Compare
k8s-ci-robot
added
size/XL
xing-yang
reviewed
May 7, 2021
krishchow
force-pushed
the
remove-protocol-name
branch
from
984874f to
265ce70
Compare
xing-yang
reviewed
May 7, 2021
spec.md
Outdated
| // If the principal is set, then it should be used as the username of the created credentials. | ||
| // If the principal is empty, then a new service account should be created in the backend that satisfies the requested access_policy. | ||
| // The principal returned in the response will be used as the unique identifier for deleting this access by calling ProvisionerRevokeBucketAccess. | ||
| // This call grants access to an account. The account_name in the request shall be used a unique identifier to create credentials. |
krishchow
force-pushed
the
remove-protocol-name
branch
from
265ce70 to
392ee58
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishchow, wlan0, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 11, 2021
This bumps the version of the spec to that of May 4th, 2021, including the changes introduced in 392ee587932b2c764d9600854b049897f0979b4e. See: kubernetes-retired/container-object-storage-interface-spec@392ee58 See: kubernetes-retired/container-object-storage-interface-spec#27
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 11, 2021
This bumps the version of the spec to that of May 4th, 2021, including the changes introduced in 392ee587932b2c764d9600854b049897f0979b4e. See: kubernetes-retired/container-object-storage-interface-spec@392ee58 See: kubernetes-retired/container-object-storage-interface-spec#27
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 11, 2021
This bumps the version of the spec to that of May 4th, 2021, including the changes introduced in 392ee587932b2c764d9600854b049897f0979b4e. See: kubernetes-retired/container-object-storage-interface-spec@392ee58 See: kubernetes-retired/container-object-storage-interface-spec#27
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 11, 2021
This bumps the version of the spec to that of May 4th, 2021, including the changes introduced in 392ee587932b2c764d9600854b049897f0979b4e. The tests show a potential issue in the CSI driver, see https://kubernetes.slack.com/archives/C017EGC1C6N/p1620729488311200. See: kubernetes-retired/container-object-storage-interface-spec@392ee58 See: kubernetes-retired/container-object-storage-interface-spec#27
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 11, 2021
This bumps the version of the spec to that of May 4th, 2021, including the changes introduced in 392ee587932b2c764d9600854b049897f0979b4e. The tests show a potential issue in the CSI driver, see https://kubernetes.slack.com/archives/C017EGC1C6N/p1620729488311200. See: kubernetes-retired/container-object-storage-interface-spec@392ee58 See: kubernetes-retired/container-object-storage-interface-spec#27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to mirror kubernetes-retired/container-object-storage-interface-api#41 and follows the discussion in the most recent community meetings.
The goal here again is to remove redundant fields. Namely, we had
bucketNamein the s3/gcs protocols, andcontainerNamein the azure protocol. These fields have all been superseded by BucketID.