-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
Welcome @shanduur! |
Hi @shanduur. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I hope we can add more such events in future to the recorder
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanduur, thotz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
During one of the SIG-Storage COSI meetings in February we discussed adding Event recording capabilities.
This is 2nd out of 3 pull requests across all repos (api/controller/provisioner-sidecar) with implementation of those changes.
WIP until kubernetes-retired/container-object-storage-interface-api#64 is merged.