Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Fix the build files so that prow job can run successfully #30

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix the build files so that prow job can run successfully #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ FROM gcr.io/distroless/static:latest
LABEL maintainers="Kubernetes Authors"
LABEL description="COSI Controller"

COPY ./bin/cosi-controller-manager cosi-controller-manager
ENTRYPOINT ["/cosi-controller-manager"]
COPY ./bin/controller-manager controller-manager
ENTRYPOINT ["/controller-manager"]
8 changes: 7 additions & 1 deletion deploy/base/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: objectstorage-controller-role
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd this needs to be added, and not expected. Could you elaborate why these were added? kustomize (or kubectl -k) should take care of these already.

labels:
app.kubernetes.io/part-of: container-object-storage-interface
app.kubernetes.io/component: controller
Expand All @@ -25,7 +26,8 @@ rules:
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: system:objectstorage-controller
name: objectstorage-controller
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ClusterRoleBinding doesn't have a namespace.

labels:
app.kubernetes.io/part-of: container-object-storage-interface
app.kubernetes.io/component: controller
Expand All @@ -34,6 +36,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: objectstorage-controller-sa
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as https://github.com/kubernetes-sigs/container-object-storage-interface-controller/pull/30/files#r553022404

roleRef:
kind: ClusterRole
name: objectstorage-controller-role
Expand All @@ -43,6 +46,7 @@ kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: objectstorage-controller
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as https://github.com/kubernetes-sigs/container-object-storage-interface-controller/pull/30/files#r553022404

labels:
app.kubernetes.io/part-of: container-object-storage-interface
app.kubernetes.io/component: controller
Expand All @@ -57,6 +61,7 @@ kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: objectstorage-controller
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as https://github.com/kubernetes-sigs/container-object-storage-interface-controller/pull/30/files#r553022404

labels:
app.kubernetes.io/part-of: container-object-storage-interface
app.kubernetes.io/component: controller
Expand All @@ -65,6 +70,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: objectstorage-controller-sa
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as https://github.com/kubernetes-sigs/container-object-storage-interface-controller/pull/30/files#r553022404

roleRef:
kind: Role
name: objectstorage-controller
Expand Down