Added EventRecorder to the Controller

[shanduur]

During one of the SIG-Storage COSI meetings in February we discussed adding Event recording capabilities.

This is 2nd out of 3 pull requests across all repos (api/controller/provisioner-sidecar) with implementation of those changes.

Ref:

• Added EventRecorder and EventBroadcaster container-object-storage-interface-api#67
• Added volume controller style events package container-object-storage-interface-api#68

[k8s-ci-robot]

Hi @shanduur. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BlaineEXE]

I'm curious why some errors log but don't record events, and there is one error that records an event but doesn't log. Would it be better to wrap the provisionBucketClaimOperation() in a function that automatically handles logging and event recording when there is any error provisioning a bucket?

[BlaineEXE]

I'm not sure if IsNotFound() handles the nil case. Would it be better for this to be something like below, or am I missing something?

if err != nil {
    if kubeerrors.IsNotFound(err) {
        b.recordEvent( ... )  
    }
    klog.V(3)....
    return err
}

[xing-yang]

/ok-to-test

[BlaineEXE]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, shanduur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BlaineEXE]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BlaineEXE]

/lgtm