Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

add kubebuilder suggested e2e and lint targets #96

Merged

Conversation

BlaineEXE
Copy link
Contributor

Add the test-e2e, lint, and lint-fix targets that are suggested by kubebuilder, with adjustments to work for COSI monorepo.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@BlaineEXE BlaineEXE force-pushed the add-e2e-lint-targets branch from a7e4f26 to a4d916b Compare September 9, 2024 20:05
Add the test-e2e, lint, and lint-fix targets that are suggested by
kubebuilder, with adjustments to work for COSI monorepo.

Signed-off-by: Blaine Gardner <[email protected]>
Copy link
Contributor

@shanduur shanduur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, shanduur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f96c07a into kubernetes-retired:monorepo Sep 27, 2024
4 checks passed
@BlaineEXE BlaineEXE deleted the add-e2e-lint-targets branch October 3, 2024 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants