This repository was archived by the owner on Dec 6, 2024. It is now read-only.
monorepo: rename 'controller' dir to 'internal/runtime' #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
BlaineEXE
force-pushed
the
rename-controller-to-runtime
branch
from
51bba65 to
0a81b2f
Compare
k8s-ci-robot
added
size/L
We want to use the top-level dir 'controller' for new controller code and go module. The existing 'controller' code is a shared set of listeners for watching COSI resources. Since this code is shared by the controller and sidecar, it needs to be available to both. It doesn't need to be made available to other projects, so the Golang 'internal' dir can be used. Signed-off-by: Blaine Gardner <[email protected]>
BlaineEXE
force-pushed
the
rename-controller-to-runtime
branch
from
0a81b2f to
471a592
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
BlaineEXE
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the top-level dir 'controller' for new controller code
and go module. The existing 'controller' code is a shared set of
listeners for watching COSI resources. Since this code is shared by the
controller and sidecar, it needs to be available to both. It doesn't
need to be made available to other projects, so the Golang 'internal'
dir can be used.
Merge after #89