This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Adding a object reference that can be used as a reference to BR, BAR … #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
brahmaroutu
force-pushed
the
fix_objectreferences
branch
2 times, most recently
from
305bb84 to
2a2c1b7
Compare
brahmaroutu
force-pushed
the
fix_objectreferences
branch
from
2a2c1b7 to
092e8ea
Compare
|
I prefer this approach tbh. This is more idiomatic of how references are held in k8s api. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wlan0
added
the
do-not-merge/hold
|
I've added a hold because I want @xing-yang/@rrati to take a look |
|
LGTM |
|
/lgtm |
wlan0
removed
the
do-not-merge/hold
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
…tions Create proto definitions for cosi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and SA
This is a discrepancy between the Spec and API definitions. BA should have following fields BucketAccessRequest and ServiceAccount of type ObjectReference instead of string.
/assign @wlan0