This repository was archived by the owner on Dec 6, 2024. It is now read-only.
monorepo: update client/api generators #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Update client/api generation tools. Do so by establishing a go mod for client separate from the top-level go mod. At this point, a top-level go mod is unnecessary, so remove it and the top-level vendor dir as well. Create a basic client/Makefile that runs all generators and basic code vetting. This will likely change some in the future but establishes basic expectations about how the current client code can be generated and checked for basic issues. Signed-off-by: Blaine Gardner <[email protected]>
BlaineEXE
force-pushed
the
modernize-client-gen
branch
from
227f709 to
4ebb2a4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Aug 2, 2024
…ooling implement mvp release tooling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update client/api generation tools. Do so by establishing a go mod for client separate from the top-level go mod. At this point, a top-level go mod is unnecessary, so remove it and the top-level vendor dir as well.
Create a basic client/Makefile that runs all generators and basic code vetting. This will likely change some in the future but establishes basic expectations about how the current client code can be generated and checked for basic issues.
Brief overview of changes to help review: