This repository was archived by the owner on Dec 6, 2024. It is now read-only.
fix controller logic to prevent concurrent map reads and writes #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
krishchow
reviewed
Mar 22, 2021
controller/controller.go
Outdated
Comment on lines
394
to
403
| if op, ok := c.opMap[uuid]; ok { | ||
| if op, ok := c.opMap.Load(uuid); ok { | ||
| if _, ok := op.(updateOp); ok { | ||
| return fmt.Errorf("cannot add already added object: %s", key) | ||
| err := fmt.Errorf("cannot add already added object: %s", key) | ||
| return err | ||
| } | ||
| } | ||
| c.opMap[uuid] = addOp{ | ||
| c.opMap.Store(uuid, addOp{ | ||
| Object: d.Object, | ||
| AddFunc: &add, | ||
| Key: key, | ||
| Indexer: indexer, | ||
| } | ||
| }) |
There was a problem hiding this comment.
Could we combine this by using c.opMap.LoadOrStore /nit
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
Remove log levels and use klog v2
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
Remove log levels and use klog v2
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
updated README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a special case where under heavy load there was a concurrent map read and write. This fixes that