Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

update go module name #21

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Conversation

wlan0
Copy link
Contributor

@wlan0 wlan0 commented Feb 24, 2021

  • from github.com/kubernetes-sigs/... to sigs.k8s.io/...
  • run codegen

  - from github.com/kubernetes-sigs/... to sigs.k8s.io/...
  - run codegen
@wlan0 wlan0 requested a review from brahmaroutu February 24, 2021 23:14
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from msau42 February 24, 2021 23:14
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2021
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: (devel)
controller-gen.kubebuilder.io/version: v0.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this manually generated version? I am not sure how we come up with the number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not manually set. It is automatically set by go.mod and then set by the codegenerator

@brahmaroutu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7c26b4f into kubernetes-retired:master Feb 25, 2021
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
Added binary source and build target
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
Added binary source and build target
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
…ernetes-retired#21

 - Remove opaque parameters from ProvisionerDeleteBucket
 - Makefile fixes
 - Add comments in cosi.proto
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
Define Protocol message and use in ProvisionerCreateBucketRequest kubernetes-retired#21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants