🌱 Checks for feature flag during VM reconciliation #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the check for the state of the anti affinity feature flag when reconciling VM. When reconciling the VM, the cluster module info should be looked up only when the NodeAntiAffinity feature flag is turned on. This also solves the issue when the control plane provider is something other than the KubeadmControlPlane, in which case we do not want to allow checks for cluster module info. Signed-off-by: Sagar Muchhal <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.5 |
|
@srm09: new pull request created: #1717 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the check for the state of the anti affinity feature flag when reconciling VM. When reconciling the VM, the cluster module info should be looked up only when the NodeAntiAffinity feature flag is turned on. This also solves the issue when the control plane provider is something other than the KubeadmControlPlane, in which case we do not want to allow checks for cluster module info.
Which issue(s) this PR fixes:
Fixes #1702
Special notes for your reviewer:
n/a
Release note: