Skip to content

🌱 Bump CAPI to v1.7.0 #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

🌱 Bump CAPI to v1.7.0 #2012

merged 1 commit into from
Apr 18, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Apr 11, 2024 •
edited
Loading

Fixes ##1945

TODO:

  • Wait for CAPI v1.7.0 release and bump again

The pointer->ptr change is required because pointer is now deprecated. Given that it's going to be a nightmare to rebase, I looked into merging it now, but we can't because k8s/utils/ptr is new in 1.29, and we only want to bump that with the CAPI dep. It wasn't so bad. I submitted #2014

/hold

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and jichenjc April 11, 2024 15:20
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 11, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2877d01
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66214c5c6d0fbc000882472e
😎 Deploy Preview https://deploy-preview-2012--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 11, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 11, 2024

/test all

@mdbooth mdbooth mentioned this pull request Apr 11, 2024
Merged
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 11, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 12, 2024

/test all

@huxcrux
Copy link
Contributor

huxcrux commented Apr 17, 2024

CAPI 1.7.0 has now been released :)
Looks like it should just be a version bump needed 🤞
https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.7.0

@mdbooth mdbooth changed the title 🌱 Bump CAPI to v1.7.0-rc.1 🌱 Bump CAPI to v1.7.0 Apr 17, 2024
@mdbooth mdbooth marked this pull request as ready for review April 17, 2024 17:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from EmilienM April 17, 2024 17:03
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

Flake: #2029

/test pull-cluster-api-provider-openstack-test

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

I think I'm going to leave the hold in place until this is rebased on top of #2028 and we've run the upgrade test against 1.7.

lentzi90
lentzi90 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@MaysaMacedo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0e9c95c into kubernetes-sigs:main Apr 18, 2024
9 of 10 checks passed
@mdbooth mdbooth deleted the capi-v1.7 branch April 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 approved these changes

@dulek dulek Awaiting requested review from dulek

@jichenjc jichenjc Awaiting requested review from jichenjc

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdbooth @k8s-ci-robot @huxcrux @MaysaMacedo @lentzi90