🌱 Split v1alpha6 & v1alpha7 conversion into multiple files #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/XXL
This is 100% code motion with no code changes whatsoever. conversion.go has become unwieldy, making changes to it harder to understand. This simply splits it into several files based on the corresponding _types.go. We don't touch v1alpha5 as it's about to be deleted. It can stay a mess.
mdbooth
force-pushed
the
conversion_cleanup
branch
from
6241209 to
1eca090
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Thank you! This was going to be a massive merge conflict magnet 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 100% code motion with no code changes whatsoever.
conversion.go has become unwieldy, making changes to it harder to
understand. This simply splits it into several files based on the
corresponding _types.go.
We don't touch v1alpha5 as it's about to be deleted. It can stay a mess.
Note that this is currently based on top of #1920. We could merge it separately fairly easily. The only conflict there is the addition of the Convertible interface on
OpenStackClusterTemplateList. However, I'm hoping the webhooks change can merge quickly./hold