Skip to content

Revert "✨ Bump Go to 1.22.0" #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Contributor

Reverts #1877

We need to wait for CAPI & controller-runtime being bumped first.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 335cc94
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ce2a9b3ac2ed0008434769
😎 Deploy Preview https://deploy-preview-1879--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Feb 15, 2024

Is this just because of the tilt configuration?

@EmilienM
Copy link
Contributor Author

Is this just because of the tilt configuration?

I have issues with Tilt yes. Also I think it's a bit risky to upgrade Go if our parent projects (CAPI) hasn't, but I'm maybe wrong on good practices here.

@EmilienM
Copy link
Contributor Author

If you think it's fine to use latest go here, I'm happy to hack things on my side to get Tilt working. I'm just worried we want a bit fast for this one, and I thought we would follow CAPI.

@EmilienM
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Feb 16, 2024

If you think it's fine to use latest go here, I'm happy to hack things on my side to get Tilt working. I'm just worried we want a bit fast for this one, and I thought we would follow CAPI.

I'm pretty sure that go module boundaries allow different modules to use different go versions safely. I wonder if the tilt issue can be resolved by bumping the tilt builder image in https://github.com/kubernetes-sigs/cluster-api/blob/main/Tiltfile.

Tilt is an important workflow so I'm happy to be pragmatic here if staying in lockstep with CAPI is the simplest solution, but it's inevitably going to bite us from time to time so it's worth looking into fixing it directly if possible.

@EmilienM EmilienM closed this Feb 19, 2024
@EmilienM EmilienM deleted the revert-1877-go1.22 branch February 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants