-
Notifications
You must be signed in to change notification settings - Fork 270
Revert "✨ Bump Go to 1.22.0" #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Is this just because of the tilt configuration? |
I have issues with Tilt yes. Also I think it's a bit risky to upgrade Go if our parent projects (CAPI) hasn't, but I'm maybe wrong on good practices here. |
If you think it's fine to use latest go here, I'm happy to hack things on my side to get Tilt working. I'm just worried we want a bit fast for this one, and I thought we would follow CAPI. |
/hold |
I'm pretty sure that go module boundaries allow different modules to use different go versions safely. I wonder if the tilt issue can be resolved by bumping the tilt builder image in https://github.com/kubernetes-sigs/cluster-api/blob/main/Tiltfile. Tilt is an important workflow so I'm happy to be pragmatic here if staying in lockstep with CAPI is the simplest solution, but it's inevitably going to bite us from time to time so it's worth looking into fixing it directly if possible. |
Reverts #1877
We need to wait for CAPI & controller-runtime being bumped first.