Skip to content

⚠️ Add v1alpha8 #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

⚠️ Add v1alpha8 #1782

merged 1 commit into from
Dec 14, 2023

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 7, 2023

Add a new v1alpha8 API version.

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit f549ede
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6579c0c84e77d000082f100a
😎 Deploy Preview https://deploy-preview-1782--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 7, 2023
EmilienM
EmilienM commented Dec 7, 2023
View reviewed changes
EmilienM
EmilienM commented Dec 7, 2023
View reviewed changes
@mdbooth
Copy link
Contributor

mdbooth commented Dec 7, 2023

You'll have to make some changes in v1alpha7. Off the top of my head:

  • It's no longer a conversion Hub
  • It doesn't have webhooks any more (delete these entirely after copying to v1alpha8)
  • It's no longer a stored version (this is a code marker; check one of the other versions for the syntax)

@EmilienM EmilienM changed the title Add v1alpha8 ⚠️ Add v1alpha8 Dec 7, 2023
@EmilienM EmilienM mentioned this pull request Dec 7, 2023
Merged
3 tasks
@EmilienM EmilienM force-pushed the v1alpha8 branch 6 times, most recently from 0e1cf84 to eb768c7 Compare December 8, 2023 14:17
@mdbooth
Copy link
Contributor

mdbooth commented Dec 12, 2023

/approve

@lentzi90 @jichenjc Can I check both of you folks are ok with adding v1alpha8? If so, would you be able to give this an LGTM?

I've given this a quick sanity check, but these changes are effectively too large to be reviewable. The tests pass, which is the most important thing, and it won't be in the 0.9 release so we have some runway to fix any lingering issues that may pop up.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@lentzi90
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Putting on hold so others can check
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@EmilienM
Copy link
Contributor Author

Sounds like the upgrade hasn't worked:

Error: failed to get provider components for the "openstack:v0.8.0" provider: failed to read "components.yaml" from provider's repository "infrastructure-openstack": failed to read file "/logs/artifacts/repository/infrastructure-openstack/v0.8.0/components.yaml" from local release v0.8.0: stat /logs/artifacts/repository/infrastructure-openstack/v0.8.0/components.yaml: no such file or directory

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

1 similar comment
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Dec 14, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3ceeeae into kubernetes-sigs:main Dec 14, 2023
@mdbooth mdbooth deleted the v1alpha8 branch December 14, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilienM @mdbooth @k8s-ci-robot @lentzi90