Skip to content

🌱 Use k8s v1.28 in tests #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

🌱 Use k8s v1.28 in tests #1723

merged 1 commit into from
Oct 19, 2023

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Oct 12, 2023 •
edited
Loading

Bump Kubernetes to v1.28.2 for e2e tests and bump envtest Kubernetes
version to v1.28.0. Also removes the now unused USE_CI_ARTIFACTS
environment variable that was set in some places.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit bf13ebd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/652f6d414bab8700087b4fca
😎 Deploy Preview https://deploy-preview-1723--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2023
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90 lentzi90 force-pushed the lentzi90/test-k8s-v1.28.2 branch from aadda55 to 14629a7 Compare October 12, 2023 12:52
@lentzi90 lentzi90 marked this pull request as ready for review October 12, 2023 12:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@lentzi90 lentzi90 changed the title 🌱 WIP: Use k8s v1.28 in tests 🌱 Use k8s v1.28 in tests Oct 12, 2023
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor Author

I cannot find the issue. Rerunning to rule out flake...
/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor Author

🤦 triggered wrong test...
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

I am more confused than ever. It failed in a completely different way
/test pull-cluster-api-provider-openstack-e2e-test

@mdbooth
Copy link
Contributor

mdbooth commented Oct 13, 2023

/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

@tormath1 could there be something wrong with the flatcar image? I created it with image-builder in the same way as I did the ubuntu image. Any special settings needed?
I'm a bit lost on why it fails, but it has failed 2 times in the flatcar test. I will debug more myself also a bit later

@tormath1
Copy link
Contributor

@tormath1 could there be something wrong with the flatcar image? I created it with image-builder in the same way as I did the ubuntu image. Any special settings needed? I'm a bit lost on why it fails, but it has failed 2 times in the flatcar test. I will debug more myself also a bit later

Hello @lentzi90, thanks for working on this.

I created it with image-builder in the same way as I did the ubuntu image

Then my first guess is that the OEM_ID has not been provided? Flatcar will boot thinking is a qemu image and not an openstack image (-> it will not fetch the Ignition configuration).
This is the documentation I follow to build new Flatcar images for CAPO: https://gist.github.com/tormath1/acbae5c6cd12420bb8ea137e25655c99 - I suggested once to add this as a maintainer-notes.md documentation.

@lentzi90
Copy link
Contributor Author

Thanks @tormath1 ! I have built a new image and uploaded. Let's see how it goes! 🤞
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Fantastic! It worked! 🙂 Thanks again for the help!

@lentzi90
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@lentzi90
Use k8s v1.28 in tests
bf13ebd 
Bump Kubernetes to v1.28.2 for e2e tests and bump envtest Kubernetes
version to v1.28.0. Also removes the now unused USE_CI_ARTIFACTS
environment variable that was set in some places.
@lentzi90 lentzi90 force-pushed the lentzi90/test-k8s-v1.28.2 branch from 14629a7 to bf13ebd Compare October 18, 2023 05:29
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2023
@lentzi90
Copy link
Contributor Author

Updated the table in the readme. I just added v1.28 to it and did not remove any of the older versions or check marks. My reasoning is that we have, for example, tested CAPO v1alpha6 with k8s v1.23 at some point so the check mark is still valid, even though we do not currently test it.

@jichenjc
Copy link
Contributor

did not remove any of the older versions or check marks. My reasoning is that we have, for example, tested CAPO v1alpha6 with k8s v1.23 at some point so the check mark is still valid, even though we do not currently test it.

@jichenjc
Copy link
Contributor

did not remove any of the older versions or check marks. My reasoning is that we have, for example, tested CAPO v1alpha6 with k8s v1.23 at some point so the check mark is still valid, even though we do not currently test it.

we can achieve those older version at some point later and keep newer enough info

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3853737 into kubernetes-sigs:main Oct 19, 2023
@lentzi90 lentzi90 deleted the lentzi90/test-k8s-v1.28.2 branch October 19, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lentzi90 @k8s-ci-robot @mdbooth @tormath1 @jichenjc