Skip to content

update test from yoga to zed in devstack #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

use latest devstack

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 9da2cfc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63982e6433d2bc000898dc13
😎 Deploy Preview https://deploy-preview-1398--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@@ -3,7 +3,7 @@
# Copyright 2021 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# may not use this file except in compliance with the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI got upset that you dropped this

Copy link
Contributor Author

@jichenjc jichenjc Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submit this PR before I drink my first tea that day~ :)

will update :)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2022
@jichenjc jichenjc force-pushed the update_openstack branch 4 times, most recently from d3d64af to 926523a Compare November 28, 2022 07:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2022
@jichenjc jichenjc force-pushed the update_openstack branch 3 times, most recently from d059bfe to 9c435ef Compare November 29, 2022 02:31
@jichenjc
Copy link
Contributor Author

jichenjc commented Dec 6, 2022

/test pull-cluster-api-provider-openstack-e2e-test

@tobiasgiese
Copy link
Member

tobiasgiese commented Dec 6, 2022

@jichenjc I think your tests will be green after #1408 is merged.
Btw, you probably want to create a new amphora image with the update to zed. Or simply mirror it as described by @mnaser here #1407 (comment)

@jichenjc
Copy link
Contributor Author

jichenjc commented Dec 6, 2022

no, my problem is devstack encounter issue after switch to zed, I am comparing logs between CPO an CAPO
as CPO already moved to zed and it works fine...

@tobiasgiese
Copy link
Member

no, my problem is devstack encounter issue after switch to zed, I am comparing logs between CPO an CAPO as CPO already moved to zed and it works fine...

Sure, you're right. It was just because another PR was also failing because of the outdated ubuntu image :)

@jichenjc
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor Author

no idea why this happen, continue to check

Feb 18 10:14:10 capo-e2e-controller neutron-server[133808]: �[00;36mINFO neutron.wsgi [�[00;36m-�[00;36m] �[01;35m�[00;36m10.0.3.15 "GET /networking/v2.0/extensions HTTP/1.1" status: 404 len: 195 time: 0.0027072�[00m�[00m

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 9da2cfc link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2023
Copy link
Contributor

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lentzi90
Copy link
Contributor

I don't know all the details, but regarding trunk I think it is because we have at least one test that makes use of it.

// assert trunked port is created.
Eventually(func() int {
plist, err = shared.DumpOpenStackPorts(e2eCtx, ports.ListOpts{Description: "trunked", Tags: testTag})
Expect(err).To(BeNil())
return len(plist)
}, e2eCtx.E2EConfig.GetIntervals(specName, "wait-worker-nodes")...).Should(Equal(1))

@dulek
Copy link
Contributor

dulek commented Jun 28, 2023

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/hack/ci/cloud-init/controller.yaml.tpl#L38-L40

is there any reason we're adding those explicit services like trunk etc?

This is how you enable neutron extensions in general.

@jichenjc
Copy link
Contributor Author

This is how you enable neutron extensions in general.

right, I have no idea why it's failing , no time to dig into detail though..

@dulek
Copy link
Contributor

dulek commented Jun 29, 2023

This is how you enable neutron extensions in general.

right, I have no idea why it's failing , no time to dig into detail though..

Sounds like a job for me, I'll check.

@dulek
Copy link
Contributor

dulek commented Jun 29, 2023

I've created #1598 to be able to play with this.

@mdbooth
Copy link
Contributor

mdbooth commented Oct 10, 2023

Closing in favour of #1598, which I may also close.

@mdbooth mdbooth closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants