🌱 Ensure that python and pip is installed for e2e and conformance tests #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Giese <[email protected]>
k8s-ci-robot
added
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
approved
tobiasgiese
changed the title
|
/test pull-cluster-api-provider-openstack-conformance-test |
|
/retest
|
|
/test pull-cluster-api-provider-openstack-conformance-test |
3 tasks
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Giese [email protected]
What this PR does / why we need it:
We have to ensure that
pythonandpipare installed for our boskos resource management.In kubernetes/test-infra#26900 (comment) we've learned that python is only an artifact of bazel in the
gcr.io/k8s-staging-test-infra/kubekins-e2eimage. Therefore, we have to ensure that it's installed.We can think about rewriting our
boskos.pyin a go binary to not have the python dependency.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold
Tobias Giese [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum