Skip to content

move chrischdi to emeritus_approvers #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

move chrischdi to emeritus_approvers #1233

merged 1 commit into from
May 5, 2022

Conversation

chrischdi
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 73d151f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6272592790dc16000802fa13
😎 Deploy Preview https://deploy-preview-1233--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from apricote and mdbooth May 4, 2022 10:45
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@apricote
Copy link
Member

apricote commented May 4, 2022

Thanks for all your work and good luck in core CAPI :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@jichenjc
Copy link
Contributor

jichenjc commented May 5, 2022

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit f31ff32 into kubernetes-sigs:main May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Contributor

mdbooth commented May 5, 2022

/cherry-pick release-0.6

@mdbooth
Copy link
Contributor

mdbooth commented May 5, 2022

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 5, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@mdbooth: new pull request created: #1234

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 5, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@mdbooth: new pull request created: #1235

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth approved these changes

@apricote apricote Awaiting requested review from apricote

Assignees

@apricote apricote

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrischdi @apricote @jichenjc @k8s-ci-robot @mdbooth @k8s-infra-cherrypick-robot