Setting allowAllInClusterTraffic without managedSecurityGroups has no effect

[mdbooth]

/kind feature

By itself, setting:

spec:
  ...
  allowAllInClusterTraffic: true

will not allow all in cluster traffic. This is because it is a setting of managed security groups, which must also be enabled for this to take effect.

This described in the doc text, but when #1826 lands we have the opportunity to do better.

If we moved allowAllInClusterTraffic into the new SecurityGroupsSpec, then it would be impossible to set it without also enabling managed security groups. The configuration would become:

spec:
  ...
  managedSecurityGroups:
    allowAllInClusterTraffic: true

[mdbooth]

@mkjpryor Any objection to this?

[EmilienM]

/assign EmilienM

[EmilienM]

I'll work on it once #1826 has merged.

[mkjpryor]

I'm happy with this as long as the conversion works