Fix trivy scan flow

[Prajyot-Parab]

What this PR does / why we need it:

• Fix trivy scan flow

avoid build error -

Error: /home/runner/go/pkg/mod/github.com/aquasecurity/[email protected]/pkg/fanal/image/daemon/docker.go:66:58: cannot use c.ImageSave (value of type func(ctx context.Context, imageIDs []string, saveOpts ..."github.com/docker/docker/client".ImageSaveOption) (io.ReadCloser, error)) as imageSave value in argument to imageOpener

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2328

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fix trivy scan flow

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	6677f3a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/680b59803e4a540008811b97
😎 Deploy Preview	https://deploy-preview-2310.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Prajyot-Parab]

/cc @Amulyam24

[Amulyam24]

@Prajyot-Parab, any reason for adding a new script for installing trivy?

currently we are updating the version and installing via make.

[Prajyot-Parab]

@Prajyot-Parab, any reason for adding a new script for installing trivy?

currently we are updating the version and installing via make.

The present approach to build binary fails with following error -

Error: /home/runner/go/pkg/mod/github.com/aquasecurity/[email protected]/pkg/fanal/image/daemon/docker.go:66:58: cannot use c.ImageSave (value of type func(ctx context.Context, imageIDs []string, saveOpts ..."github.com/docker/docker/client".ImageSaveOption) (io.ReadCloser, error)) as imageSave value in argument to imageOpener

This is because the docker package getting installed is not compatible with the one trivy needs, (as some other package needs latest docker), so now I am switching to directly download the binary rather than building it, this is inline with CAPI approach.

[Amulyam24]

Can we remove the duplicate code which will not be used?
https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/hack/tools/Makefile#L129-L131

[mkumatag]

The challenge with this approach is that you will not be able to run this on ppc64le environment.

[Prajyot-Parab]

The challenge with this approach is that you will not be able to run this on ppc64le environment.

agreed. However this seems like the only way right now to get trivy scans to work for now (once the build issue is fixed in future release of trivy we can revert back to that approach)

[Prajyot-Parab]

Can we remove the duplicate code which will not be used? https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/hack/tools/Makefile#L129-L131

As per my prior comment, we will switch back to that approach once we have present build issue fixed in future trivy release, hence I was of opinion to keep the code for now.

[Amulyam24]

/lgtm

[Amulyam24]

/hold

[Amulyam24]

/retest

[Prajyot-Parab]

Can we remove the duplicate code which will not be used? https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/hack/tools/Makefile#L129-L131

Yes removed, trivy is available for ppc64le as well so this approach should hold good in future too.

[Prajyot-Parab]

/unhold

[Amulyam24]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Prajyot-Parab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment