Skip to content

Bump github.com/golangci/golangci-lint from 1.59.1 to 1.64.8 in /hack/tools #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Apr 2, 2025

What this PR does / why we need it:

  • Bump github.com/golangci/golangci-lint from 1.59.1 to 1.64.8 in /hack/tools

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump github.com/golangci/golangci-lint from 1.59.1 to 1.64.8 in /hack/tools

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2025
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24

@k8s-ci-robot k8s-ci-robot requested a review from Amulyam24 April 2, 2025 10:52
Copy link

netlify bot commented Apr 2, 2025

👷 Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud processing.

Name Link
🔨 Latest commit 04eca85
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67ed16c5b4b00000083e58e9

Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 04eca85
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67ed16c5b4b00000083e58e9
😎 Deploy Preview https://deploy-preview-2293.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve wrong instruction :P

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member

mkumatag commented Apr 2, 2025

@Prajyot-Parab can you please update why are we making this change? is this deprecated or any other reason for this change?

@Prajyot-Parab
Copy link
Contributor Author

@Prajyot-Parab can you please update why are we making this change? is this deprecated or any other reason for this change?

Yes, exportloopref is deprecated and replaced by copyloopvar.

WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. 
INFO [lintersdb] Active 41 linters: [asasalint asciicheck bodyclose containedctx decorder dogsled errcheck errchkjson exportloopref gci goconst gocritic gocyclo godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign misspell nakedret nilerr noctx nolintlint nosprintfhostport prealloc predeclared reassign revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace] 
INFO [loader] Using build tags: [tools e2e]       
INFO [loader] Go packages loading at mode 8767 (exports_file|imports|types_sizes|compiled_files|deps|files|name) took 33.48233575s 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 16.890167ms 
ERRO [linters_context] exportloopref: This linter is fully inactivated: it will not produce any reports. 

@Amulyam24
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 059630f into kubernetes-sigs:main Apr 3, 2025
13 of 14 checks passed
@Prajyot-Parab Prajyot-Parab deleted the manifest branch April 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants