Skip to content

Bump gcb-docker-gcloud to v20241229-5dc092c636 #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • Bump gcb-docker-gcloud to v20241229-5dc092c636

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2261

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump gcb-docker-gcloud to v20241229-5dc092c636

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 2eac82b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67dc53915ceca80008d14c11
😎 Deploy Preview https://deploy-preview-2262.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does bumping the version fixes the issue?

@mkumatag
Copy link
Member

How does bumping the version fixes the issue?

in the latest image, they have changed the golang version and here is the reference - kubernetes/test-infra#34159

@mkumatag
Copy link
Member

How does bumping the version fixes the issue?

in the latest image, they have changed the golang version and here is the reference - kubernetes/test-infra#34159

The failing stack it this:

mkdir -p bin
CGO_ENABLED=0 go build -tags=capibmtools -o bin/kustomize sigs.k8s.io/kustomize/kustomize/v5
go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
make[4]: Leaving directory '/workspace/hack/tools'
make[4]: *** [Makefile:69: bin/kustomize] Error 1
make[3]: *** [common.mk:9: hack/tools/bin/kustomize] Error 2
make[3]: Leaving directory '/workspace'
make[2]: *** [Makefile:374: out/infrastructure-components.yaml] Error 2
make[2]: Leaving directory '/workspace'
make[1]: Leaving directory '/workspace'
make[1]: *** [Makefile:327: staging-manifests] Error 2.  <================ Failure step.
make: *** [Makefile:320: release-staging] Error 2

IMO we need to find a way not to use the gcloud images's golang version and we should be controlling the version we want to use to build the tools and commands we are using.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this as a temporary fix and for long run we need to use our own golang tool for building artifacts and don't depend on the gcb-docker-gcloud image
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6463334 into kubernetes-sigs:main Mar 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post-cluster-api-provider-ibmcloud-push-images job is failing
4 participants