-
Notifications
You must be signed in to change notification settings - Fork 89
Bump gcb-docker-gcloud to v20241229-5dc092c636 #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Prajyot Parab <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does bumping the version fixes the issue?
in the latest image, they have changed the golang version and here is the reference - kubernetes/test-infra#34159 |
The failing stack it this:
IMO we need to find a way not to use the gcloud images's golang version and we should be controlling the version we want to use to build the tools and commands we are using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge this as a temporary fix and for long run we need to use our own golang tool for building artifacts and don't depend on the gcb-docker-gcloud image
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2261
Special notes for your reviewer:
/area provider/ibmcloud
Release note: