-
Notifications
You must be signed in to change notification settings - Fork 89
Add support for pausing cluster reconcilation #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/hold |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
51d7ea1
to
7fd342e
Compare
Not able to completely test the end to end flow with create-infra workflow (I could see the machines are going into emergency mode, this is not related to this PR. |
Tested on cluster with infra create workflow and works as expected. on setting
|
Ready for review |
72c5cb1
to
da823c1
Compare
Even this PR is ready for review Trying to delete a paused machine
|
/cc @dharaneeshvrd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm.
One suggestion is that, if you can document how to use this feature that would be great IMO.
da823c1
to
cec2ee6
Compare
Re-based and updated the PR |
Thanks, This change is more towards developer oriented, Use case is to pause the reconciliation when external controller is handling it.
Thought no need of having it under capibm book as there is no mention about it in capi book as well. Please let me know your opinion. |
Ok fine in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharaneeshvrd, Karthik-K-N, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds support for pausing a cluster reconcilation, to facilitate that it adds event filters and predicates while setting up the controller.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1730
Special notes for your reviewer:
/area provider/ibmcloud
Release note: