Update ttlcache library to v3, disable TTL extension on hit #338

hrak · 2024-01-17T14:33:10Z

Issue #, if available:

Fixes #336

Description of changes:

This PR gives the ttlcache library a major update and disables TTL extension on cache item hit.

Testing performed:

make test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

netlify · 2024-01-17T14:33:19Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	`2f1182c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/664f201447ef5f00087397c5
😎 Deploy Preview	https://deploy-preview-338--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter · 2024-01-17T14:39:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (207f0a2) 25.45% compared to head (781dee8) 25.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   25.45%   25.52%   +0.06%     
==========================================
  Files          59       59              
  Lines        5555     5560       +5     
==========================================
+ Hits         1414     1419       +5     
  Misses       4002     4002              
  Partials      139      139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

g-gaston · 2024-01-23T14:44:03Z

Thanks for the PR @hrak!
A bit caught up right now but I will get to it :)

Signed-off-by: Hans Rakers <[email protected]>

g-gaston

thanks for the fix!

g-gaston · 2024-02-12T15:45:09Z

pkg/cloud/client.go

 	"github.com/apache/cloudstack-go/v2/cloudstack"
+	ttlcache "github.com/jellydator/ttlcache/v3"


nit: is the alias needed?

+1. We don't need the alias here.

g-gaston · 2024-02-12T15:47:24Z

pkg/cloud/client.go

+		var client interface{} = item.Value()
 		return client.(Client), nil


this is more for my own understanding than a request for change
But, why is casting required ifttlcache.Cache is parametrized with the types for key and value?

k8s-triage-robot · 2024-05-12T16:26:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pkg/cloud/client.go

vishesh92 · 2024-05-20T09:57:57Z

@hrak some minor code changes required.

vishesh92 · 2024-05-20T09:58:16Z

/ok-to-test

g-gaston · 2024-05-20T16:16:34Z

/remove-lifecycle stale

pkg/cloud/client.go

Co-authored-by: Vishesh <[email protected]>

rohityadavcloud · 2024-05-23T12:03:16Z

/retest

blueorangutan · 2024-05-23T15:01:57Z

Test Results : (tid-427)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.27.2
Kubernetes Version upgrade from: v1.26.5
Kubernetes Version upgrade to: v1.27.2
CloudStack Version: 4.19
Template: ubuntu-2004-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr338-sl-427.zip



Summarizing 1 Failure:
  [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
  /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinedeployment_helpers.go:127

Ran 28 of 29 Specs in 10734.848 seconds
FAIL! -- 27 Passed | 1 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (10734.85s)
FAIL

k8s-ci-robot · 2024-05-23T15:02:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrak, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vishesh92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vishesh92 · 2024-05-23T19:34:52Z

/lgtm

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 17, 2024

k8s-ci-robot requested a review from g-gaston January 17, 2024 14:33

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2024

k8s-ci-robot requested a review from jweite-amazon January 17, 2024 14:33

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024

hrak force-pushed the ttl_fix branch from 781dee8 to 27ac3c4 Compare February 5, 2024 14:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024

Update ttlcache library to v3, disable TTL extension on hit

cf6ce73

Signed-off-by: Hans Rakers <[email protected]>

hrak force-pushed the ttl_fix branch from 27ac3c4 to cf6ce73 Compare February 5, 2024 14:30

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 5, 2024

g-gaston reviewed Feb 12, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2024

rohityadavcloud added this to the v0.5.0 milestone May 20, 2024

rohityadavcloud added the release:must-have label May 20, 2024

rohityadavcloud requested a review from vishesh92 May 20, 2024 07:05

vishesh92 reviewed May 20, 2024

View reviewed changes

pkg/cloud/client.go Outdated Show resolved Hide resolved

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 20, 2024

rohityadavcloud assigned vishesh92 May 20, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2024

vishesh92 reviewed May 21, 2024

View reviewed changes

pkg/cloud/client.go Outdated Show resolved Hide resolved

rohityadavcloud and others added 2 commits May 23, 2024 16:22

Update pkg/cloud/client.go

2979184

Co-authored-by: Vishesh <[email protected]>

Update pkg/cloud/client.go

2f1182c

Co-authored-by: Vishesh <[email protected]>

vishesh92 approved these changes May 23, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024

k8s-ci-robot merged commit 54c8213 into kubernetes-sigs:main May 23, 2024
10 checks passed

		"github.com/apache/cloudstack-go/v2/cloudstack"
		ttlcache "github.com/jellydator/ttlcache/v3"

		var client interface{} = item.Value()
		return client.(Client), nil

Update ttlcache library to v3, disable TTL extension on hit #338

Update ttlcache library to v3, disable TTL extension on hit #338

Uh oh!

Conversation

hrak commented Jan 17, 2024

Uh oh!

netlify bot commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Uh oh!

codecov-commenter commented Jan 17, 2024

Codecov Report

Uh oh!

g-gaston commented Jan 23, 2024

Uh oh!

g-gaston left a comment

Choose a reason for hiding this comment

Uh oh!

g-gaston Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

vishesh92 May 20, 2024

Choose a reason for hiding this comment

Uh oh!

g-gaston Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented May 12, 2024

Uh oh!

Uh oh!

vishesh92 commented May 20, 2024

Uh oh!

vishesh92 commented May 20, 2024

Uh oh!

g-gaston commented May 20, 2024

Uh oh!

Uh oh!

rohityadavcloud commented May 23, 2024

Uh oh!

blueorangutan commented May 23, 2024

Uh oh!

k8s-ci-robot commented May 23, 2024

Uh oh!

vishesh92 commented May 23, 2024

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 17, 2024 •

edited

Loading