-
Notifications
You must be signed in to change notification settings - Fork 604
🐛 fix: oidc test failure #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: oidc test failure #5352
Conversation
Moving back to WIP as it needs some more changes. |
050bd2a
to
7ccabe0
Compare
This updates the oidc test to fix the cert thumbprints from the server as these change with every go version when using httptest.NewTLSServer. Signed-off-by: Richard Case <[email protected]>
7ccabe0
to
3f3da41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @richardcase
/lgtm
/approved |
/cherrypick release-2.7 |
@richardcase: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@richardcase typo in the |
Thanks @damdo /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@richardcase: new pull request created: #5353 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@richardcase: new pull request created: #5354 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The OIDC tests use
httpTest.NewTLSServer
and uses a hard coded certificate (see go src) and we rely on the hash of this certificate in the tests (here) as part of gomock assertions.The certificate changes with every new go version and the image used by the Prow job has been changed (see PR) and now uses Go v1.22.12, so the certificates no longer match and the test fails
This updates the oidc test to use our own hard coded certificate with corresponding thumbprints.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5351
Special notes for your reviewer:
Checklist:
Release note: