🌱 Update testing to use NLB for controlPlaneLoadBalancer

[damdo]

What type of PR is this?
/kind support

What this PR does / why we need it:

Update testing to use NLB for controlPlaneLoadBalancer, as ELBs don't work with k8s >= 1.30

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Release note:

NONE

[damdo]

/test pull-cluster-api-provider-aws-e2e pull-cluster-api-provider-aws-e2e-eks

[damdo]

/assign @nrb @richardcase

[damdo]

E2Es are passing with this change.

[richardcase]

/approve

Thanks @damdo .

It would then be good to update all the non-eks templates (in /templates) with the same configuration

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndiDog]

Have we discussed to set the default to NLB in the future? If so, I'm fine with these kind of changes. I remember we discussed that some migration path would be needed.

[nrb]

Have we discussed to set the default to NLB in the future?

Yes, we'll begin the deprecation notification cycle for changing the default type of NLB with v2.8's release. The plan was outlined in this comment

[Ankitasw]

/lgtm

[damdo]

/hold

[damdo]

/unhold

[damdo]

Thanks @damdo .
It would then be good to update all the non-eks templates (in /templates) with the same configuration

@richardcase I put up #5345 for that