[backport 0.7] Fixes an issue with using multiple EKS addons. #2961
Conversation
k8s-ci-robot
added
release-note
|
@richardcase: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-triage
k8s-ci-robot
added
the
size/L
|
/retitle [backport] fix: support more than 1 eks addon |
k8s-ci-robot
changed the title
When the EKS addons functionality was added to CAPA there was only 1 addon available (vpc) and so it was never tested with multiple addons. Now there are multiple addons there are issues. The unit and e2e tests only tested 1 addons. On investigation the issue was caused by implicit memory aliasing in a loop. This change fixes the loop and also expands the unit and e2e tests to include multiple eks addons Signed-off-by: Richard Case <[email protected]>
|
/retitle [backport 0.7] Fixes an issue with using multiple EKS addons. |
k8s-ci-robot
changed the title
|
/test? |
|
@sedefsavas: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-aws-e2e-eks-release-0-7 |
|
The eks e2e passed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the EKS addons functionality was added to CAPA there was only 1
addon available (vpc) and so it was never tested with multiple addons.
Now there are multiple addons there are issues.
The unit and e2e tests only tested 1 addons. On investigation the issue
was caused by implicit memory aliasing in a loop. This change fixes the
loop and also expands the unit and e2e tests to include multiple eks
addons
Backport of #2914
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates #2911
Special notes for your reviewer:
Checklist:
Release note: