-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix IngressClassParams CRD singular naming to resolve SingularConflict #4201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix IngressClassParams CRD singular naming to resolve SingularConflict #4201
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laradji The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @laradji! |
Hi @laradji. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
98d2b08
to
9131d4d
Compare
9131d4d
to
6ef8a09
Compare
6ef8a09
to
1bebab9
Compare
1bebab9
to
2f03bcb
Compare
/ok-to-test |
Fixes #4200
Changes singular name from 'ingressclassparams' to 'ingressclassparam'
to follow Kubernetes naming conventions and resolve the SingularConflict
condition causing NamesAccepted: False status.
Issue
Description
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯