-
Notifications
You must be signed in to change notification settings - Fork 10
Add Volume deletion validation #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Volume deletion validation #68
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: phuhung273 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @phuhung273! |
Hi @phuhung273. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thank you so much, really appreciate for quick help. Unfortunately sanity test is failing. I will try to get it fixed asap :( |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Hi @hughdanliu, please help take a look when you have time. Thanks |
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
Delete
, retryDescribe
exponentially to validate deletion until timeout.Delete
handle both JSON string\"fs-1234\"
and actual resource IDfs-1234
Extra
controller_test
What testing is done?
Unit + Sanity