-
Notifications
You must be signed in to change notification settings - Fork 114
CGO_ENABLED=0 in building linux binary #346
Conversation
|
Welcome @mist714! |
Hi @mist714. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test @adrianludwin any concerns here? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mist714, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current binary is dynamic-executable.
This is unavoidable for MacOS and Windows, but since Linux environments are required to operate under the minimum necessary conditions, I think we should make not a dynamic executable but a single-binary.
The concern is that the size will increase, but it is smaller than the original binary (62.2 MB -> 47 MB)