-
Notifications
You must be signed in to change notification settings - Fork 114
docs: improve grammar and simplify HRQ examples #315
docs: improve grammar and simplify HRQ examples #315
Conversation
Hi @agilgur5. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
04d6342
to
7ab1912
Compare
7ab1912
to
da5cd04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change!
/lgtm
/approve
Hi @agilgur5 , sorry for the long delay, but could you please rebase this change? I think the tests will pass after that's done. Thanks! |
Was reading through the docs and these seemed the most verbose - it seems to be a very recent feature as well, from 3aef487 - use same heading in both Quickstart and Concepts, including HRQ abbreviation - use abbreviation to shorten the HRQ docs themselves as well - fix run-on sentences by adding punctuation - "by default, to use it" -> "by default. To use it" - add missing commas - "Then,", "finally,", etc - add Oxford commas - ", but", ", and", ", or", etc - simplify several sentences, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#use-simple-and-direct-language) - "won't be over the amount of resources that is configured in `HierarchicalResourceQuota`" -> "cannot surpass the HRQ" - "can't go over what is configured in the HRQ" -> "can't surpass the HRQ" - "And put the resources HRQ in" -> "An HRQ in" - "This will restrict whole" -> "restricts" (also uses present tense now, per style guide) - "the amount of resources that" -> "the resources" "resource usage" -> "resources" - "automatically creates" -> "creates" - in a similar vein, remove or replace ambiguous language - "equally shared" -> "shared" -- they can be shared however, not necessarily "equally" - "which is very efficient" -> "" -- "efficient" could be interpreted in a performance sense and is unnecesary - "lower level", "level" -> "child" / "sub" -- use HNC's existing terminology instead of "lower level", which has multiple disambiguations - Similarly use HNC's existing terminology for: - "individual", "members" -> "namespace", "subnamespaces" - "above", "overall" -> "parent" - "wins" -> "applies" -- replace idiom, per [style guide](https://kubernetes.io/docs/contribute/style/style-guide/#avoid-jargon-and-idioms) - clarify a few sentences with a single word - "within", "Instead", "still", "directly" - consolidate the two paragraphs on command-line usage into one - looks like they were added at different times, in 564b4a9 - they largely duplicated each other with slighlty different wording - creating an HRQ via a CR YAML is the definition of how CRs work, which are already used across HNC, so not necessary to re-explain - also remove the word "simply", per [style guide](https://kubernetes.io/docs/contribute/style/style-guide/#avoid-words-that-assume-a-specific-level-of-understanding) There are potentially more changes that could be made according to the style guide, but I primarily limited changes to simplifications, clarifications, and grammar
da5cd04
to
8daf912
Compare
@adrianludwin rebased. It needs to be re-approved now |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, agilgur5, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Summary
Was reading through the docs and these seemed the most verbose
Details
Grammar
Simplifications
simplify several sentences, per k8s style guide
HierarchicalResourceQuota
" -> "cannot surpass the HRQ"in a similar vein, remove or replace ambiguous language
clarify a few sentences with a single word
consolidate the two paragraphs on command-line usage into one
Review Notes
There are potentially more changes that could be made according to the style guide, but I primarily focused changes on simplifications, clarifications, and grammar
Misc
This is a great example! It gives very practical, real-world use-cases which is very helpful for context and understanding how one might use HNC!