This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Remove obsolete validation TODOs #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some TODOs when improving the error messages from webhook validation. Most of these were suggesting to review, and eventually change, the status code returned. I realize now that this is probably not feasible, and apologize for adding the TODOs in the first place.
Tested: Ran both unit-tests ('make test') and integration test ('make test-e2e') successfully.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some TODOs when improving the error messages from webhook validation. Most of these were suggesting to review, and eventually change, the status code returned. I realize now that this is probably not feasible, and apologize for adding the TODOs in the first place.
Tested: Ran both unit-tests ('make test') and integration test ('make test-e2e') successfully.