This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Refactor adding/removing/contains finalizers #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I'm not really seeing how this change improves the organization of the finalizers? It replaces some custom code with a slightly safe utility function but that's it, AIUI. I'm ok with the change (other than one caveat) but I'm wondering if I missed something in the review, or if this PR was supposed to include something that got lost somehow? |
erikgb
force-pushed
the
improve/finalizers
branch
from
bb33c3d to
ba82ef0
Compare
erikgb
changed the title
|
Ok, take 2 ready. PTAL! |
erikgb
changed the title
To be able to distinguish between updating just the status and updating the full resource in a follow-up PR.
Tested: Ran both unit-tests ('make test') and integration test ('make test-e2e') successfully.
erikgb
force-pushed
the
improve/finalizers
branch
from
ba82ef0 to
811b9aa
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to distinguish between updating just the status and updating the full resource (in a follow-up PR). A controller should just update the status of the controlling resource, with some exceptions - i.e. finalizers. Currently HNC always updates the complete resource, and not just the status, and this has to be fixed to open up for #142.
Tested: Ran both unit-tests ('make test') and integration test ('make test-e2e') successfully.
Relates to #200.