Add security context

[rgherta]

Fixes #181
Tested: test-smoke, test-e2e

go clean --testcache
go test -v -timeout 0 ./test/e2e/... -args --ginkgo.focus "Quickstart"
=== RUN   TestE2e
Running Suite: HNC Suite
========================
Random Seed: 1650309465
Will run 5 of 36 specs

SSSSSSSSSSSSSSSSSS
------------------------------
• [SLOW TEST:30.375 seconds]
Quickstart
/home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:11
  Should test basic functionalities in quickstart
  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:33
------------------------------
• [SLOW TEST:30.292 seconds]
Quickstart
/home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:11
  Should propagate different types
  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:81
------------------------------

S [SKIPPING] [67.745 seconds]
Quickstart
/home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:11
  Should integrate hierarchical network policy [It]
  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:105

  Basic network policies don't appear to be working; skipping the netpol quickstart

  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:165
------------------------------
• [SLOW TEST:62.344 seconds]
Quickstart
/home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:11
  Should create and delete subnamespaces
  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:194
------------------------------


• [SLOW TEST:22.588 seconds]
Quickstart
/home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:11
  Should demonstrate exceptions
  /home/romang/Documents/hierarchical-namespaces/test/e2e/quickstart_test.go:253
------------------------------
SSSSSSSSSSSSS

Ran 4 of 36 Specs in 213.345 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 32 Skipped

[k8s-ci-robot]

Hi @rgherta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tashimi]

ping @adrianludwin @rjbez17

/unassign @tashimi

[adrianludwin]

Hey @rgherta , thanks for this! Before I approve, can you please make a few changes?

• The tests you ran didn't exercise your changes - the test/e2e would have tested them, but they take about 15-30m to run. To run those tests, point your kubectl at a cluster, run make deploy to deploy HNC onto that cluster, then run make test-smoke (this runs a subset of the e2e tests and should only take about 5min). Can you please run those?
• Can you please give the commit a more descriptive name? E.g. "Add pod security contexts" or whatever the correct name of this feature is. Please also include the details about why you're making this change, any other details that might be useful, plus what testing you did in the commit, not the PR description. A good example is 75a2052.
  • For this change, the "Tested:" paragraph might just be Tested: make smoke-test passes

Thanks!

[adrianludwin]

BTW you can update the commit message just by git commit --amend and then force-push it to your branch, probably something like git push origin -f, you don't need to close this PR and file a new one.

[adrianludwin]

Hey @rgherta , do you need a hand on this? Is everything clear?

[rgherta]

Hey @rgherta , do you need a hand on this? Is everything clear?

all clear, sorry for thr delay

[adrianludwin]

No worries! LMK if you have any questions about running the tests.

[adrianludwin]

lgtm but I wouldn't mind if Ryan could have look as well. Thanks for making this change!

/approve
/lgtm
/hold
/assign @rjbez17

[adrianludwin]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rgherta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianludwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rjbez17]

/lgtm
/hold cancel