Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

fixes #181 #186

Closed
wants to merge 1 commit into from
Closed

fixes #181 #186

wants to merge 1 commit into from

Conversation

rgherta
Copy link
Contributor

@rgherta rgherta commented Apr 5, 2022

Tested:
ok sigs.k8s.io/hierarchical-namespaces/internal/anchor 0.026s coverage: 14.9% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/config 0.049s coverage: 18.8% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/forest 0.043s coverage: 25.1% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/hierarchyconfig 0.099s coverage: 23.8% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/hncconfig 0.023s coverage: 25.7% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/namespace 0.020s coverage: 59.8% of statements
ok sigs.k8s.io/hierarchical-namespaces/internal/objects 0.018s coverage: 35.3% of statements
ok sigs.k8s.io/hierarchical-namespaces/test/e2e 0.002s

Tested:
ok      sigs.k8s.io/hierarchical-namespaces/internal/anchor     0.026s  coverage: 14.9% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/config     0.049s  coverage: 18.8% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/forest     0.043s  coverage: 25.1% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/hierarchyconfig    0.099s  coverage: 23.8% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/hncconfig  0.023s  coverage: 25.7% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/namespace  0.020s  coverage: 59.8% of statements
ok      sigs.k8s.io/hierarchical-namespaces/internal/objects    0.018s  coverage: 35.3% of statements
ok      sigs.k8s.io/hierarchical-namespaces/test/e2e    0.002s
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rgherta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rgherta
To complete the pull request process, please assign srampal after the PR has been reviewed.
You can assign the PR to them by writing /assign @srampal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2022
@rgherta rgherta closed this Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants