This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Import HRQ into HNC (disabled by default) #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rjbez17
reviewed
Apr 6, 2022
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
This implementation of Hierarchical Resource Quotas (HRQs) is based on the implementation from the GKE Hierarchy Controller. It's not a straight import since the GKE version was deployed as a separate workload, but I've made minimal adaptations to get it to fit into HNC. Tested: This has only been _very_ lightly tested in HNC so far. I've imported all the integ tests and E2E tests, and they all pass, but I certainly wouldn't recommend that anyone use it just yet (all existing e2e tests pass too). The default manifest includes the HRQ CRD and permissions but nothing else (notably, the HRQ webhooks), and one feature - the periodic resync of HRQ usages - is not yet implemented (I'll do that in a followup PR).
|
/lgtm |
|
Third time's the charm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of Hierarchical Resource Quotas (HRQs) is based on
the implementation from the GKE Hierarchy Controller. It's not a
straight import since the GKE version was deployed as a separate
workload, but I've made minimal adaptations to get it to fit into HNC.
Tested: This has only been very lightly tested in HNC so far. I've
imported all the integ tests and E2E tests, and they all pass, but I
certainly wouldn't recommend that anyone use it just yet. The default
manifest includes the HRQ CRD and permissions but nothing else (notably,
the HRQ webhooks), and one feature - the periodic resync of HRQ usages -
is not yet implemented (I'll do that in a followup PR).