This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Simplify condition handling #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While implementing managed labels, I found two problems with our condition handling: 1. They were using old terminology like "Critical Condition" instead of the newer "ActivitiesHalted". 2. Instead of identifying problems like cycles right away, we delayed their identification until the end of the syncing process. This means that code that depends on knowing about cycles - like setting tree labels - needed to be at the end of the sync process instead of in the middle where they belonged (and couldn't set conditions themselves). This change fixes both problems. Tested: all existing unit/integ tests; no change in functionality.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I forget if I can self-approve or not... /lgtm |
|
@adrianludwin: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nope :) Will wait for Ryan |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing managed labels, I found two problems with our
condition handling:
the newer "ActivitiesHalted".
their identification until the end of the syncing process. This means
that code that depends on knowing about cycles - like setting tree
labels - needed to be at the end of the sync process instead of in the
middle where they belonged (and couldn't set conditions themselves).
This change fixes both problems.
Tested: all existing unit/integ tests; no change in functionality.