Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

updated README.md and added spec.md #15

Merged
merged 1 commit into from
Dec 17, 2020
Merged

updated README.md and added spec.md #15

merged 1 commit into from
Dec 17, 2020

Conversation

somersbmatthews
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @somersbmatthews!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-spec 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-spec has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@somersbmatthews
Copy link
Contributor Author

#14

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2020
@wlan0
Copy link
Contributor

wlan0 commented Dec 14, 2020

thanks @somersbmatthews

@wlan0
Copy link
Contributor

wlan0 commented Dec 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 14, 2020
@wlan0
Copy link
Contributor

wlan0 commented Dec 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 14, 2020
brahmaroutu
brahmaroutu reviewed Dec 15, 2020
View reviewed changes
sajanjswl
sajanjswl reviewed Dec 15, 2020
View reviewed changes
README.md Outdated
| [Controller](https://github.com/kubernetes-sigs/container-object-storage-interface-controller) | [cosi-controller](https://quay.io/repository/containerobjectstorage/objectstorage-controller?tab=tags) |
| [Provisioner Sidecar](https://github.com/kubernetes-sigs/container-object-storage-interface-provisioner-sidecar) | cosi-provisioner TODO |
| [CSI Adapter](https://github.com/kubernetes-sigs/container-object-storage-interface-csi-adapter) | cosi-node-adapter TODO |
\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no images created on quay.io to my knowledge for the provisioner-sidecar and the CSI adapter. Were you referring to something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, will fix

@somersbmatthews somersbmatthews mentioned this pull request Dec 15, 2020
Merged
xing-yang
xing-yang reviewed Dec 15, 2020
View reviewed changes
README.md
[Manager (i.e. Controller)](https://github.com/container-object-storage-interface/cosi-controller-manager) \
[Provisioner Sidecar](https://github.com/container-object-storage-interface/cosi-provisioner-sidecar) \
[Ephemeral CSI Driver](https://github.com/container-object-storage-interface/ephemeral-csi-driver)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table does not look right:

https://github.com/kubernetes-sigs/container-object-storage-interface-spec/blob/63d3ccc27e80c3eb2db3b09520d7665716cff5f7/README.md

@somersbmatthews
Copy link
Contributor Author

@sajanjswl @xing-yang squashed commits and removed table.

@somersbmatthews
updated README.md and added spec.md
2958448 
fixed spacing typo in README.md

added repo/images table to README.md

added images to README.md

changed name of adapter image in README.md

changed urls in README.md

attempt to fix newline after table in README.md

added newline in README.md

added headers to README.md

removed html break in README.md

removed table from README.md

reformated repos and images

added hyphen in README.md

removed punctuation in README.md
@somersbmatthews
Copy link
Contributor Author

/assign @msau42

@xing-yang
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sajanjswl, somersbmatthews, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8cbf84d into kubernetes-retired:master Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xing-yang xing-yang xing-yang left review comments

@brahmaroutu brahmaroutu brahmaroutu left review comments

@sajanjswl sajanjswl sajanjswl approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@wlan0 wlan0

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@somersbmatthews @k8s-ci-robot @wlan0 @xing-yang @brahmaroutu @sajanjswl @msau42