Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Added bucket controller #9

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Added bucket controller #9

merged 1 commit into from
Dec 20, 2020

Conversation

rrati
Copy link

@rrati rrati commented Dec 9, 2020

No description provided.

@rrati
Copy link
Author

rrati commented Dec 9, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rrati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2020
@rrati
Copy link
Author

rrati commented Dec 9, 2020

wait to merge until this is resolved:
kubernetes-retired/container-object-storage-interface-spec#12

@rrati
Copy link
Author

rrati commented Dec 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@rrati
Copy link
Author

rrati commented Dec 10, 2020

There's a fake client in the spec repo now.

brahmaroutu
brahmaroutu reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@brahmaroutu brahmaroutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, test cases are comprehensive.
I think we should add some for Anonymous Access mode support.
otherwise LGTM

@rrati rrati added this to the Demo 1 milestone Dec 11, 2020
@rrati
Copy link
Author

rrati commented Dec 16, 2020

Part of #8

@rrati
Copy link
Author

rrati commented Dec 16, 2020

part of #6

@rrati rrati force-pushed the bucket-controller branch from 078232d to 763b228 Compare December 18, 2020 17:16
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2020
@rrati rrati force-pushed the bucket-controller branch from 763b228 to 8d3c30e Compare December 19, 2020 00:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2020
@rrati rrati force-pushed the bucket-controller branch from 8d3c30e to 9195ed3 Compare December 19, 2020 01:42
brahmaroutu
brahmaroutu reviewed Dec 20, 2020
View reviewed changes
@brahmaroutu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit f3f77c7 into kubernetes-retired:master Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brahmaroutu brahmaroutu brahmaroutu left review comments

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@brahmaroutu brahmaroutu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Demo 1
Development

Successfully merging this pull request may close these issues.
3 participants
@rrati @k8s-ci-robot @brahmaroutu