Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Fix: Add DeleteContext to DriverDeleteBucket and fix delete BucketAccess flow #74

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Fix: Add DeleteContext to DriverDeleteBucket and fix delete BucketAccess flow #74

merged 7 commits into from
Oct 13, 2022

Conversation

mukhoakash
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot requested a review from rrati September 29, 2022 15:39
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2022
@k8s-ci-robot k8s-ci-robot requested a review from wlan0 September 29, 2022 15:39
@mukhoakash
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2022
@mukhoakash mukhoakash force-pushed the finalizer_fix branch 5 times, most recently from 4b6f339 to a7e8888 Compare September 29, 2022 16:29
@mukhoakash
Copy link
Contributor Author

@wlan0 Could you please take a look at this PR.

@mukhoakash mukhoakash changed the title Fixed deletion of secrets and updated finalizer for BucketAccess Fix: Add DeleteContext to DriverDeleteBucket and fix delete BucketAccess flow Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mukhoakash, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@wlan0 wlan0 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 459c723 into kubernetes-retired:master Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@rrati rrati Awaiting requested review from rrati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukhoakash @k8s-ci-robot @wlan0