Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

added kustomize template & k8s resources for sidecar #24

Merged
merged 1 commit into from
Jan 11, 2021
Merged

added kustomize template & k8s resources for sidecar #24

merged 1 commit into from
Jan 11, 2021

Conversation

tparikh
Copy link
Contributor

@tparikh tparikh commented Jan 8, 2021

#23

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @tparikh!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-provisioner-sidecar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-provisioner-sidecar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @tparikh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2021
NicolasT
NicolasT reviewed Jan 8, 2021
View reviewed changes
deploy/base/deployment.yaml Outdated
kind: Deployment
metadata:
name: objectstorage-provisioner
namespace: objectstorage-provisioner-ns
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, you shouldn't provide a namespace here. This can either be set in kustomization.yaml, or passed to kubectl apply -k I believe (-n).

(Also applies to other occurrences)

deploy/base/deployment.yaml Outdated
Comment on lines 14 to 20
minReadySeconds: 30
progressDeadlineSeconds: 600
revisionHistoryLimit: 3
strategy:
type: RollingUpdate
rollingUpdate:
maxSurge: 1
maxUnavailable: 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these any different from the defaults? Are they required to be set to these values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these values are different from defaults. By default maxUnavailable is 25%. Since we are only running with single pod here, we should not terminate the old pod until the new pod is ready.

deploy/base/deployment.yaml Outdated
cpu: 100m
memory: 100Mi
env:
- name: CONNECT_ADDRESS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the relation between a CONNECT_ADDRESS environment variable set from a LISTEN_ADDRESS field in some Secret? I'm a bit confused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrati Might be able to answer this question

deploy/base/kustomization.yaml Outdated
kind: Kustomization

resources:
- ns.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO a kustomization layer, especially a base one, should not create any NS.

deploy/base/secret.yaml Outdated
Comment on lines 13 to 14
stringData:
LISTEN_ADDRESS: 0.0.0.0:9000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who'll be listening here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrati might be able to shed some light on this

@wlan0
Copy link
Contributor

wlan0 commented Jan 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2021
@wlan0
Copy link
Contributor

wlan0 commented Jan 11, 2021

The changes look good. We might have to revisit the namespaces once again in the future, esp. in case of multiple provisioners in the same cluster.

@wlan0
Copy link
Contributor

wlan0 commented Jan 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tparikh, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit a6e9768 into kubernetes-retired:master Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasT NicolasT NicolasT left review comments

@wlan0 wlan0 wlan0 approved these changes

@brahmaroutu brahmaroutu Awaiting requested review from brahmaroutu

@rrati rrati Awaiting requested review from rrati

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tparikh @k8s-ci-robot @wlan0 @NicolasT