Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Adding minio-driver #11

Closed
wants to merge 1 commit into from
Closed

Adding minio-driver #11

wants to merge 1 commit into from

Conversation

sajanjswl
Copy link
Contributor

Signed-off-by: Sajan Jaiswal [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @sajanjswl!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-provisioner-sidecar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-provisioner-sidecar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sajanjswl
To complete the pull request process, please assign rrati after the PR has been reviewed.
You can assign the PR to them by writing /assign @rrati in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 9, 2020
@rrati rrati added this to the Demo 1 milestone Dec 16, 2020
Signed-off-by: Sajan Jaiswal <[email protected]>
@rrati
Copy link

rrati commented Dec 16, 2020

Part of #8

@rrati
Copy link

rrati commented Dec 16, 2020

/closes #5

}

func (ds DriverServer) ProvisionerCreateBucket(ctx context.Context, req *cosi.ProvisionerCreateBucketRequest) (*cosi.ProvisionerCreateBucketResponse, error) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is empty?

@wlan0
Copy link
Contributor

wlan0 commented Dec 17, 2020

I dont like the idea of having an entirely different go dependency tree for a proejct under the same root. Let's discuss how to simplify this. cc @rrati

@rrati
Copy link

rrati commented Dec 17, 2020

@wlan0 Agreed. It was always intended to pull the example provisioner into the main build structure, we just didn't get there before the move. This seems like a perfect time to correct that and not put the sample provisioner in its own tree.

@k8s-ci-robot
Copy link
Contributor

@sajanjswl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2020
@rrati
Copy link

rrati commented Jan 12, 2021

/close

Done as part of #27

@rrati rrati closed this Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants