Add BucketAccess Controller #10
Conversation
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rrati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
wait to merge until this is resolved: |
k8s-ci-robot
added
approved
|
There is a fake client in the spec repo now |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| return fmt.Errorf("unable to get bucket instance %s: %+v", bucketInstanceName, err) | ||
| } | ||
|
|
||
| req := osspec.ProvisionerGrantBucketAccessRequest{ |
There was a problem hiding this comment.
ServiceAccount should also be considered here?
| CredentialsFileContents: credsContents, | ||
| CredentialsFilePath: credsFile, | ||
| }, nil | ||
| }, |
There was a problem hiding this comment.
What is the reason we have both SA and Principal, providing one of the two is normal usecase.
There was a problem hiding this comment.
Yes, this is a mistake in the test. The principal shouldn't be returned here.
|
Part of #8 |
|
Part of #6 |
k8s-ci-robot
added
the
lgtm
No description provided.