Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Update Makefile #66

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Update Makefile #66

merged 1 commit into from
Sep 15, 2022

Conversation

wlan0
Copy link
Contributor

@wlan0 wlan0 commented Sep 8, 2022

Remove tag override

Remove tag override
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thotz, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlan0 wlan0 merged commit cde23fc into master Sep 15, 2022
@@ -28,4 +28,3 @@ CMDS=controller-manager
include release-tools/build.make

IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
IMAGE_TAGS=$(TAG)

I tried running, but while it did build and push correctly, it still gave the canary tag. I think what is happening is that the tag we want is not being added, and that build.make creates a canary image by default since no tag is found. IMAGE_TAGS is needed to add a new image, so either we could just type in our tag there, or if we need to get it from cloudbuild.yaml, replace the push arg in line 18 of cloudbuild.yaml with args: ['push', 'TAG=${_GIT_TAG}'] and commit the above changes. This will make it so cloudbuild calls push with the tag as an argument, and have the makefile accept it and add it to the tags.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants