-
Notifications
You must be signed in to change notification settings - Fork 29
Update the code with latest KEP #55
Update the code with latest KEP #55
Conversation
Signed-off-by: Jiffin Tony Thottan <[email protected]>
Signed-off-by: Jiffin Tony Thottan <[email protected]>
Signed-off-by: Jiffin Tony Thottan <[email protected]>
Welcome @mukhoakash! |
Hi @mukhoakash. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 85c7f85.
nicely done @mukhoakash! |
/ok-to-test |
please fix the build errors. Otherwise, it LGTM |
/lgtm |
/retest |
I believe this build error is due to golang version which is set here in the test-infra file. We will have to fix those versions to handle the failures. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mukhoakash, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Made the following changes: