Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Update the code with latest KEP #55

Merged
merged 25 commits into from
Jul 27, 2022

Conversation

mukhoakash
Copy link
Contributor

@mukhoakash mukhoakash commented Jul 8, 2022

Made the following changes:

  1. Introduce the new APIs
  2. Fix the code generation to use the generate-internal-groups.sh script
  3. Renamed the resource name to follow package name conventions
  4. Structured the generated client code
  5. Updated the go version and introduced vendor directory
  6. Updated README

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mukhoakash!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mukhoakash. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from rrati and wlan0 July 8, 2022 09:54
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 8, 2022
@wlan0
Copy link
Contributor

wlan0 commented Jul 14, 2022

nicely done @mukhoakash!

@wlan0
Copy link
Contributor

wlan0 commented Jul 14, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2022
@wlan0 wlan0 marked this pull request as ready for review July 14, 2022 05:46
@wlan0 wlan0 removed the request for review from rrati July 14, 2022 05:46
@wlan0
Copy link
Contributor

wlan0 commented Jul 14, 2022

please fix the build errors. Otherwise, it LGTM

@wlan0
Copy link
Contributor

wlan0 commented Jul 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@wlan0 wlan0 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@mukhoakash
Copy link
Contributor Author

/retest

@mukhoakash
Copy link
Contributor Author

please fix the build errors. Otherwise, it LGTM

I believe this build error is due to golang version which is set here in the test-infra file. We will have to fix those versions to handle the failures.

@mukhoakash mukhoakash changed the title [WIP] Update the code with latest KEP Update the code with latest KEP Jul 14, 2022
@mukhoakash
Copy link
Contributor Author

/retest

@wlan0
Copy link
Contributor

wlan0 commented Jul 27, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mukhoakash, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 02ff3dd into kubernetes-retired:master Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants