-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
wlan0
commented
Feb 24, 2021
- from github.com/kubernetes-sigs/... to sigs.k8s.io/...
- run codegen
- from github.com/kubernetes-sigs/... to sigs.k8s.io/... - run codegen
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
kind: CustomResourceDefinition | |||
metadata: | |||
annotations: | |||
controller-gen.kubebuilder.io/version: (devel) | |||
controller-gen.kubebuilder.io/version: v0.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this manually generated version? I am not sure how we come up with the number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not manually set. It is automatically set by go.mod and then set by the codegenerator
/lgtm |
Added binary source and build target
Added binary source and build target
…ernetes-retired#21 - Remove opaque parameters from ProvisionerDeleteBucket - Makefile fixes - Add comments in cosi.proto
Define Protocol message and use in ProvisionerCreateBucketRequest kubernetes-retired#21